Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claims and applications page #3504

Merged
merged 24 commits into from
Nov 13, 2024
Merged

Claims and applications page #3504

merged 24 commits into from
Nov 13, 2024

Conversation

megzehn
Copy link
Collaborator

@megzehn megzehn commented Nov 7, 2024

Creating a PR for a new special topics page: claims and applications

@megzehn megzehn marked this pull request as ready for review November 7, 2024 22:08
@megzehn megzehn requested a review from a team as a code owner November 7, 2024 22:08
@megzehn
Copy link
Collaborator Author

megzehn commented Nov 7, 2024

Hi @humancompanion-usds, this PR is ready for the content style guide. It's the special topic page about claims and applications that we showed you on a previous design/content sync. Do you mind doing a final review and merging when you have a minute?

@DanielleThierryUSDSVA and @jstrothman both reviewed and approved it.

Thank you!! CC @laurwill

@megzehn
Copy link
Collaborator Author

megzehn commented Nov 13, 2024

Hi @danbrady, I'm pinging you since Matthew's out at the offsite. Any chance you could review and merge this PR for the content style guide?

Copy link
Contributor

@danbrady danbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new page, we'll have to add it into the left side navigation so it's accessible. Also, we would usually update the "In this section" part on the page level above (in this case, "Specific topics and programs") with a link to this new page. Are you able to do that?

@@ -0,0 +1,59 @@
---
layout: content-style-guide
permalink: /content-style-guide/specific-topics-and-programs/claims
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the page was renamed to "claims and applications", so we likely want to update the permalink as well.

@danbrady danbrady assigned megzehn and unassigned danbrady Nov 13, 2024
Adding subpage
changing permalink to match title
@megzehn
Copy link
Collaborator Author

megzehn commented Nov 13, 2024

Thank you for catching that, @danbrady!! I adjusted the permalink and added it as a sub-page on the "Specific topics and programs" index page. But I don't see where to link to it or how to add it to the nav. Could you check again and see if there are more changes I need to make?

@danbrady
Copy link
Contributor

@megzehn My mistake, I forgot that the left nav updates automatically based on what's in the "sub-pages" front matter. I can see it now after you added it to that section. Looks good. Approved!

@danbrady danbrady self-requested a review November 13, 2024 19:54
@megzehn megzehn merged commit e15f62a into main Nov 13, 2024
4 checks passed
@megzehn megzehn deleted the megzehn-claims-special-topics branch November 13, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants